fix: read the settings values, not the references they arrive as

Every field is `volatile()`, which is what puts the settings card on the
Plugins page — and what makes the resolved config carry a reference per field
rather than a value. Every read was a plain-value test (`typeof x === 'string'`,
`Number(x)`, `x !== true`), so all of them were false and the plugin behaved as
if nothing had been configured.

The card displayed and persisted correctly the whole time, because the settings
wire unwraps references for display; only the plugin's own reads were broken.
Reads now go through `configValue()`, and the tool takes a fresh snapshot per
call, which is what lets an edit reach a running instance.

test/config.test.js

@@ -1,6 +1,7 @@
 import assert from 'node:assert/strict'
 import { test } from 'node:test'
 
+import { Config, configValue, settingsSnapshot, toSlopoConfig, workspacePaths } from '../index.js'
 import {
   SLOPO_CONFIG_KEYS,
   missingRequired,
@@ -105,3 +106,95 @@ test('normalizeConfig keeps thresholds fractional but rejects fractional counts'
   assert.equal(Object.hasOwn(bad.config, 'embedding_batch_size'), false)
   assert.match(bad.problems[0], /whole number/)
 })
+
+/**
+ * The other half of the config contract: the shape a section ARRIVES in.
+ *
+ * Every field of `Config` is `volatile()`, so Cordis hands `apply` a reference
+ * object per field rather than a value — that is what lets a settings edit land
+ * without re-applying the plugin. A plain-value read of such a field is silently
+ * false, which is how this plugin came to ignore its own settings and fall back
+ * to autodiscovery. These tests resolve through the real schema path, because a
+ * fixture built from plain literals can never catch that.
+ */
+
+/** The section as the Loader builds it: schema-resolved, references intact. */
+function resolved(patch = {}) {
+  const result = Config['~standard'].validate(patch)
+  assert.equal(result.issues, undefined, `the schema refused the fixture: ${JSON.stringify(result.issues)}`)
+  return result.value
+}
+
+test('a volatile field arrives as a reference, and configValue unwraps it', () => {
+  const config = resolved({ embeddingApiBase: 'http://192.0.2.10:11434' })
+  assert.equal(typeof config.embeddingApiBase, 'object', 'a volatile field is a reference, not a value')
+  assert.equal(configValue(config.embeddingApiBase), 'http://192.0.2.10:11434')
+  // …and a plain value is handed straight back, so a caller that passes a
+  // literal object — every other test in this suite, and `apply` in a profile
+  // whose fields are not volatile — takes the very same code path.
+  assert.equal(configValue('http://plain'), 'http://plain')
+  assert.equal(configValue(undefined), undefined)
+  assert.equal(configValue(0), 0)
+})
+
+test('a snapshot reads the configured values out of a schema-resolved section', () => {
+  const settings = settingsSnapshot(
+    resolved({
+      embeddingModel: 'ollama/example:latest',
+      embeddingDimensions: 768,
+      embeddingRequestDelay: 25,
+      embeddingParamsJson: '{"keep_alive":"5m"}',
+    }),
+  )
+  assert.equal(settings.embeddingModel, 'ollama/example:latest')
+  assert.equal(settings.embeddingDimensions, 768)
+  assert.equal(settings.embeddingRequestDelay, 25)
+  assert.equal(settings.embeddingParamsJson, '{"keep_alive":"5m"}')
+  // The fields left unset are still the schema's own defaults, not `undefined`.
+  assert.equal(settings.sourceDir, '')
+  assert.deepEqual(settings.sourceDirExclude, [])
+})
+
+test('toSlopoConfig turns a schema-resolved section into slopo config, not into defaults', () => {
+  // The regression: every read in this path was a plain-value check, so the
+  // model read as '' and the dimensions as undefined — the tool reported itself
+  // unconfigured while the settings card was displaying a configured one.
+  const config = resolved({
+    embeddingModel: 'ollama/example:latest',
+    embeddingDimensions: 768,
+    embeddingRequestDelay: 25,
+    embeddingApiBase: 'http://192.0.2.10:11434',
+    embeddingParamsJson: '{"keep_alive":"5m"}',
+    sourceDir: '/src',
+  })
+  const paths = workspacePaths('/home/dsh', '/work', config)
+  assert.equal(paths.sourceDir, '/src')
+  const problems = []
+  const slopoConfig = toSlopoConfig(config, paths, problems)
+  assert.deepEqual(problems, [])
+  assert.equal(slopoConfig.embedding_model, 'ollama/example:latest')
+  assert.equal(slopoConfig.embedding_dimensions, 768)
+  assert.equal(slopoConfig.embedding_request_delay, 25)
+  assert.deepEqual(slopoConfig.embedding_params, { keep_alive: '5m', api_base: 'http://192.0.2.10:11434' })
+})
+
+test('the same helpers still take a plain object, which is how they are called elsewhere', () => {
+  const paths = workspacePaths('/home/dsh', '/work', { sourceDir: '/src', stateDir: '/state' })
+  assert.equal(paths.stateDir, '/state')
+  assert.equal(paths.sourceDir, '/src')
+  const slopoConfig = toSlopoConfig({ embeddingModel: 'ollama/plain:latest', embeddingDimensions: 1024 }, paths)
+  assert.equal(slopoConfig.embedding_model, 'ollama/plain:latest')
+  assert.equal(slopoConfig.embedding_dimensions, 1024)
+})
+
+test('a snapshot taken per call sees a live edit, because the reference is written in place', () => {
+  const config = resolved({ embeddingDimensions: 768 })
+  assert.equal(settingsSnapshot(config).embeddingDimensions, 768)
+  // This is what the Loader does on a volatile-only settings change: it writes
+  // the new value into the reference the running instance already holds, without
+  // re-applying the plugin. A snapshot cached at apply time would never see it,
+  // which is why the tool takes a fresh one per call.
+  const [write] = Object.getOwnPropertySymbols(config.embeddingDimensions)
+  config.embeddingDimensions[write](1024)
+  assert.equal(settingsSnapshot(config).embeddingDimensions, 1024)
+})

test/plugin.test.js

@@ -101,9 +101,18 @@ writeFileSync(stubSlopo, '#!/bin/sh\nexit 0\n', { mode: 0o755 })
  *
  * `jobs` is deliberately absent, which forces the tool down its foreground path
  * so the assertions can see a result rather than a job handle.
+ *
+ * `configFromSchema` hands `apply` the config the way Cordis actually builds it
+ * — through `Config['~standard'].validate`, so every volatile field arrives as a
+ * reference object rather than a value. Without it a test can only prove the
+ * plugin works on a shape no real profile ever produces.
  */
-function harness(overrides = {}, { withSettings = true, withJobs = false, withShell = true, sandboxMode, sandboxPolicyResolver, shellRun } = {}) {
-  const config = { ...FULL_CONFIG, binary: stubSlopo, ...overrides }
+function harness(
+  overrides = {},
+  { withSettings = true, withJobs = false, withShell = true, sandboxMode, sandboxPolicyResolver, shellRun, configFromSchema = false } = {},
+) {
+  const plain = { ...FULL_CONFIG, binary: stubSlopo, ...overrides }
+  const config = configFromSchema ? resolveConfig(plain) : plain
   // A per-harness shell, so a test can vary sandboxMode and every resolved
   // request is recorded for assertion.
   const scopedShell = {
@@ -187,6 +196,13 @@ function harness(overrides = {}, { withSettings = true, withJobs = false, withSh
 
 const execContext = (cwd) => ({ signal: new AbortController().signal, agent: { id: 'session-1', session: { header: { cwd } } } })
 
+/** Resolve a fixture the way Cordis does, volatile references and all. */
+function resolveConfig(patch) {
+  const result = Config['~standard'].validate(patch)
+  assert.equal(result.issues, undefined, `the schema refused the fixture: ${JSON.stringify(result.issues)}`)
+  return result.value
+}
+
 test('Config is a schemastery schema, which is what cordis requires', () => {
   assert.equal(typeof Config, 'function')
   assert.ok(Config['~standard'] !== undefined, 'expected a Standard Schema')
@@ -281,6 +297,42 @@ test('the embedding API key is a declared secret, so the settings wire never car
   }
 })
 
+test('a schema-resolved config reaches the tool as values, not as volatile references', async () => {
+  // The regression: Cordis hands `apply` a reference object per volatile field,
+  // so every plain-value read (`typeof settings.embeddingModel === 'string'`)
+  // was false and the configured settings were silently discarded. It looked
+  // healthy because `status` fell back to autodiscovery and to whatever stale
+  // slopo.conf.yaml was already on disk.
+  const { state } = harness(
+    { embeddingModel: 'ollama/example:latest', embeddingDimensions: 768 },
+    { configFromSchema: true },
+  )
+  const value = await state.tools.get('slopo').execute({ action: 'status' }, execContext('/tmp'))
+  assert.deepEqual(value.details.missingSettings, [], 'the settings must not read as unset')
+  assert.equal(value.ok, true)
+  assert.equal(value.details.embeddingModel, 'ollama/example:latest')
+  assert.equal(value.details.embeddingDimensions, 768)
+})
+
+test('a settings edit lands in the running tool, because the snapshot is taken per call', async () => {
+  // A volatile-only write does not re-apply the plugin — the Loader writes the
+  // new value into the reference the instance already holds — so a snapshot
+  // cached in `apply` would freeze this tool at its composition values forever.
+  const { config, state } = harness(
+    { embeddingModel: 'ollama/first:latest', embeddingDimensions: 768 },
+    { configFromSchema: true },
+  )
+  const tool = state.tools.get('slopo')
+  const before = await tool.execute({ action: 'status' }, execContext('/tmp'))
+  assert.match(before.message, /ollama\/first:latest/)
+
+  const [write] = Object.getOwnPropertySymbols(config.embeddingModel)
+  config.embeddingModel[write]('ollama/second:latest')
+
+  const after = await tool.execute({ action: 'status' }, execContext('/tmp'))
+  assert.match(after.message, /ollama\/second:latest/)
+})
+
 test('status reports the missing settings instead of pretending to be ready', async () => {
   const { state } = harness()
   const tool = state.tools.get('slopo')