It rendered as a flat, always-open block with no header. The framework's card
chrome is a disclosure: the tab renders every card into a <ul>, each card's root
is an <li>, its header is its own <button> that discloses the controls in place,
it starts collapsed, the header marks it when it holds unsaved edits, and a save
that lands folds it back up.
Three things were wrong and only one of them was cosmetic:
* the root was a <div> inside the tab's <ul>, so the list and card styling
never reached it
* there was no header button, so no disclosure and no aria-expanded
* nothing marked unsaved edits, and nothing collapsed after a save
`PluginCard` is not importable — it lives in that package's client bundle, and
the client purity gate forbids cross-plugin value imports — so the behaviour is
reproduced rather than borrowed, with inline styles for the same reason.
The collapse-on-save originally lived in an effect watching a `saving` flag, which
is how the shipped card does it because its form state comes from a controller.
This card awaits its own writes, so it already knows the save landed; collapsing
directly in the success path is simpler and is what the tests can actually reach.
A failed save still keeps the card open with its drafts.
Tests cover the disclosure itself: the root element, collapsed-by-default, the
header's aria-expanded and label, that staged edits survive collapsing, and that
a landed save folds the card up.
357 lines
13 KiB
JavaScript
357 lines
13 KiB
JavaScript
/**
|
|
* Tests for the browser half.
|
|
*
|
|
* There is no browser here, so the bundle is evaluated the way the real module
|
|
* loader would — inside `window.__ModuleLoader__.load` — with a fake `require`
|
|
* that supplies React and THROWS on anything else. That last part is the useful
|
|
* one: it proves the bundle stays inside the platform's seed table, which is the
|
|
* constraint a hand-written client half is most likely to break.
|
|
*
|
|
* The card is then rendered by calling the registered component and expanding
|
|
* the elements it returns, and its handlers are driven directly. That is not a
|
|
* substitute for looking at it in a browser, but it does check the wiring the
|
|
* card cannot work without — including the disclosure chrome, which is what
|
|
* makes it look like the other cards in the tab.
|
|
*/
|
|
|
|
import assert from 'node:assert/strict'
|
|
import { readFileSync } from 'node:fs'
|
|
import { test } from 'node:test'
|
|
|
|
const SOURCE = readFileSync(new URL('../client/client.js', import.meta.url), 'utf8')
|
|
|
|
/**
|
|
* Minimal React: createElement, the three hooks the card uses, and an effect
|
|
* runner that actually invokes its callback rather than ignoring it.
|
|
*
|
|
* `useState` consumes one ordered slot per call, as real hooks do.
|
|
*/
|
|
function makeFakeReact() {
|
|
const slots = []
|
|
let cursor = 0
|
|
return {
|
|
reset() {
|
|
cursor = 0
|
|
},
|
|
api: {
|
|
createElement: (type, props, ...children) => ({ type, props: props ?? {}, children }),
|
|
useState(initial) {
|
|
const index = cursor
|
|
cursor += 1
|
|
if (!(index in slots)) slots[index] = typeof initial === 'function' ? initial() : initial
|
|
return [
|
|
slots[index],
|
|
(next) => {
|
|
slots[index] = typeof next === 'function' ? next(slots[index]) : next
|
|
},
|
|
]
|
|
},
|
|
useEffect(effect) {
|
|
effect()
|
|
},
|
|
useMemo(factory) {
|
|
return factory()
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
/** Evaluate the bundle against a fake loader and return its exports. */
|
|
function loadBundle() {
|
|
let loaded
|
|
const window = { __ModuleLoader__: { load: (spec) => { loaded = spec } } }
|
|
new Function('window', SOURCE)(window)
|
|
assert.ok(loaded !== undefined, 'the bundle must call window.__ModuleLoader__.load')
|
|
const react = makeFakeReact()
|
|
const exported = loaded.factory((name) => {
|
|
if (name === 'react') return react.api
|
|
throw new Error(`the client bundle required "${name}", which is not in the platform seed table`)
|
|
})
|
|
return { id: loaded.id, exported, react }
|
|
}
|
|
|
|
/** Resolve function components by calling them, until a host element or null. */
|
|
function expand(node, depth = 0) {
|
|
if (depth > 50) throw new Error('the component tree did not settle')
|
|
if (node === null || node === undefined) return null
|
|
if (typeof node !== 'object') return node
|
|
if (Array.isArray(node)) return node
|
|
if (typeof node.type === 'function') return expand(node.type(node.props), depth + 1)
|
|
return node
|
|
}
|
|
|
|
/** Depth-first walk over a rendered tree, expanding components as it goes. */
|
|
function findAll(node, predicate, out = []) {
|
|
if (node === null || node === undefined) return out
|
|
if (Array.isArray(node)) {
|
|
for (const child of node) findAll(child, predicate, out)
|
|
return out
|
|
}
|
|
if (typeof node !== 'object') return out
|
|
if (typeof node.type === 'function') {
|
|
findAll(expand(node), predicate, out)
|
|
return out
|
|
}
|
|
if (predicate(node)) out.push(node)
|
|
for (const child of node.children ?? []) findAll(child, predicate, out)
|
|
return out
|
|
}
|
|
|
|
function textOf(node) {
|
|
if (typeof node === 'string') return node
|
|
if (node === null || node === undefined || typeof node !== 'object') return ''
|
|
if (Array.isArray(node)) return node.map(textOf).join('')
|
|
return (node.children ?? []).map(textOf).join('')
|
|
}
|
|
|
|
/** A SettingsScope stand-in recording the writes it was asked to make. */
|
|
function fakeScope(snapshot) {
|
|
const calls = { set: [], unset: [] }
|
|
return {
|
|
calls,
|
|
getSnapshot: () => snapshot,
|
|
subscribe: () => () => {},
|
|
set: async (field, value) => {
|
|
calls.set.push([field, value])
|
|
},
|
|
unset: async (field) => {
|
|
calls.unset.push(field)
|
|
},
|
|
}
|
|
}
|
|
|
|
const READY = {
|
|
status: 'ready',
|
|
value: { embeddingModel: '', embeddingDimensions: 0 },
|
|
user: {},
|
|
base: {},
|
|
revision: 1,
|
|
writable: true,
|
|
mode: 'host',
|
|
}
|
|
|
|
/** Register the card the way the host would, and hand back its component. */
|
|
function registered() {
|
|
const { id, exported, react } = loadBundle()
|
|
let registration
|
|
let render
|
|
const ctx = {
|
|
inject(deps, callback) {
|
|
assert.deepEqual(deps, ['settingsScope'])
|
|
callback({
|
|
settingsScope: { bind: () => fakeScope(READY) },
|
|
slots: {
|
|
inject(_name, produce) {
|
|
produce()
|
|
},
|
|
register(options, component) {
|
|
registration = options
|
|
render = component
|
|
},
|
|
},
|
|
})
|
|
},
|
|
}
|
|
exported.apply(ctx)
|
|
const draw = (scope) => {
|
|
react.reset()
|
|
return expand(render({ scope }))
|
|
}
|
|
/** Render, click the header, and render again the way a state update would. */
|
|
const drawOpen = (scope) => {
|
|
const header = headerOf(draw(scope))
|
|
header.props.onClick()
|
|
return draw(scope)
|
|
}
|
|
return { id, exported, react, registration, draw, drawOpen }
|
|
}
|
|
|
|
const headerOf = (tree) =>
|
|
findAll(tree, (node) => node.type === 'button' && node.props['aria-expanded'] !== undefined)[0]
|
|
|
|
const inputFor = (tree, label) =>
|
|
findAll(tree, (node) => node.type === 'input' && node.props['aria-label'] === label)[0]
|
|
|
|
const buttonStartingWith = (tree, prefix) =>
|
|
findAll(tree, (node) => node.type === 'button' && textOf(node).startsWith(prefix))[0]
|
|
|
|
test('the bundle id matches the package name the loader is told about', () => {
|
|
const { id } = loadBundle()
|
|
assert.equal(id, 'dsh-slopo')
|
|
})
|
|
|
|
test('the client bundle requires nothing outside the platform seed table', () => {
|
|
// loadBundle() throws on any specifier other than react.
|
|
assert.doesNotThrow(() => loadBundle())
|
|
})
|
|
|
|
test('applying registers exactly one settings.plugin.item card, keyed on the namespace', () => {
|
|
const { registration, exported } = registered()
|
|
assert.equal(exported.name, 'dsh-slopo')
|
|
assert.deepEqual(exported.inject, ['slots'])
|
|
assert.equal(registration.name, 'settings.plugin.item')
|
|
// The key must equal the Host namespace, or the tab never dispatches the card.
|
|
assert.equal(registration.key, 'dsh-slopo')
|
|
})
|
|
|
|
test('the root is an <li>, because the tab renders every card into a <ul>', () => {
|
|
const { draw } = registered()
|
|
assert.equal(draw(fakeScope(READY)).type, 'li')
|
|
})
|
|
|
|
test('the card starts collapsed, with a header that says so', () => {
|
|
const { draw } = registered()
|
|
const tree = draw(fakeScope(READY))
|
|
assert.equal(headerOf(tree).props['aria-expanded'], false)
|
|
assert.match(headerOf(tree).props['aria-label'], /^Expand: /)
|
|
// Nothing is disclosed yet.
|
|
assert.equal(findAll(tree, (node) => node.type === 'input').length, 0)
|
|
})
|
|
|
|
test('clicking the header discloses every setting the Host accepts', () => {
|
|
const { drawOpen } = registered()
|
|
const tree = drawOpen(fakeScope(READY))
|
|
assert.equal(headerOf(tree).props['aria-expanded'], true)
|
|
assert.match(headerOf(tree).props['aria-label'], /^Collapse: /)
|
|
const labels = findAll(tree, (node) => node.type === 'label').map(textOf)
|
|
for (const expected of [
|
|
'Embedding model',
|
|
'Embedding dimensions',
|
|
'Embedding API base',
|
|
'Embedding API key',
|
|
'Extra embedding parameters',
|
|
'slopo executable',
|
|
'Source directory',
|
|
'Extra exclude patterns',
|
|
'State directory',
|
|
'Ignore file',
|
|
'Foreground timeout',
|
|
]) {
|
|
assert.ok(
|
|
labels.some((label) => label.includes(expected)),
|
|
`no control labelled "${expected}"`,
|
|
)
|
|
}
|
|
})
|
|
|
|
test('the API key is rendered as a password field', () => {
|
|
const { drawOpen } = registered()
|
|
const tree = drawOpen(fakeScope(READY))
|
|
assert.equal(inputFor(tree, 'Embedding API key').props.type, 'password')
|
|
})
|
|
|
|
test('the card renders nothing when the namespace is unavailable', () => {
|
|
const { draw } = registered()
|
|
assert.equal(draw(fakeScope({ ...READY, status: 'unavailable' })), null)
|
|
})
|
|
|
|
test('editing a field marks the header unsaved, and saving writes it through set()', async () => {
|
|
const { draw, drawOpen, react } = registered()
|
|
const scope = fakeScope(READY)
|
|
|
|
const open = drawOpen(scope)
|
|
inputFor(open, 'Embedding model').props.onChange({ target: { value: 'ollama/example:latest' } })
|
|
|
|
const tree = draw(scope)
|
|
// Marked on the header, so it is visible while collapsed.
|
|
assert.match(textOf(headerOf(tree)), /unsaved/)
|
|
const save = buttonStartingWith(tree, 'Save')
|
|
assert.equal(save.props.disabled, false, 'a changed field must enable Save')
|
|
await save.props.onClick()
|
|
|
|
assert.deepEqual(scope.calls.set, [['embeddingModel', 'ollama/example:latest']])
|
|
assert.deepEqual(scope.calls.unset, [])
|
|
assert.equal(react !== undefined, true)
|
|
})
|
|
|
|
test('a successful save collapses the card again', async () => {
|
|
const { draw, drawOpen } = registered()
|
|
const scope = fakeScope(READY)
|
|
inputFor(drawOpen(scope), 'Embedding model').props.onChange({ target: { value: 'ollama/x:latest' } })
|
|
await buttonStartingWith(draw(scope), 'Save').props.onClick()
|
|
|
|
// The save sets busy=false and note='Saved.', the effect collapses on the
|
|
// next render, and the one after that is the collapsed card.
|
|
draw(scope)
|
|
const settled = draw(scope)
|
|
assert.equal(headerOf(settled).props['aria-expanded'], false, 'a landed save closes the card')
|
|
assert.equal(findAll(settled, (node) => node.type === 'input').length, 0)
|
|
})
|
|
|
|
test('staged edits survive collapsing', () => {
|
|
const { draw, drawOpen } = registered()
|
|
const scope = fakeScope(READY)
|
|
inputFor(drawOpen(scope), 'Embedding model').props.onChange({ target: { value: 'ollama/kept:latest' } })
|
|
// Collapse it by hand.
|
|
headerOf(draw(scope)).props.onClick()
|
|
const collapsed = draw(scope)
|
|
assert.equal(headerOf(collapsed).props['aria-expanded'], false)
|
|
assert.match(textOf(headerOf(collapsed)), /unsaved/)
|
|
// Re-open: the draft is still there.
|
|
headerOf(collapsed).props.onClick()
|
|
assert.equal(inputFor(draw(scope), 'Embedding model').props.value, 'ollama/kept:latest')
|
|
})
|
|
|
|
test('a whole number field is sent as a number, not the string the input holds', async () => {
|
|
const { draw, drawOpen } = registered()
|
|
const scope = fakeScope(READY)
|
|
inputFor(drawOpen(scope), 'Embedding dimensions').props.onChange({ target: { value: '768' } })
|
|
await buttonStartingWith(draw(scope), 'Save').props.onClick()
|
|
assert.deepEqual(scope.calls.set, [['embeddingDimensions', 768]])
|
|
})
|
|
|
|
test('clearing a field is an unset, so it re-inherits rather than becoming empty', async () => {
|
|
const { draw, drawOpen } = registered()
|
|
const scope = fakeScope({ ...READY, value: { embeddingModel: 'ollama/old:latest', embeddingDimensions: 768 } })
|
|
inputFor(drawOpen(scope), 'Embedding model').props.onChange({ target: { value: '' } })
|
|
await buttonStartingWith(draw(scope), 'Save').props.onClick()
|
|
assert.deepEqual(scope.calls.unset, ['embeddingModel'])
|
|
assert.deepEqual(scope.calls.set, [], 'a cleared field must not be written as an empty string')
|
|
})
|
|
|
|
test('an exclude list round-trips through comma-separated text', async () => {
|
|
const { draw, drawOpen } = registered()
|
|
const scope = fakeScope({ ...READY, value: { embeddingModel: 'm', embeddingDimensions: 1 } })
|
|
inputFor(drawOpen(scope), 'Extra exclude patterns').props.onChange({ target: { value: '**/test/**, *.min.js' } })
|
|
await buttonStartingWith(draw(scope), 'Save').props.onClick()
|
|
assert.deepEqual(scope.calls.set, [['sourceDirExclude', ['**/test/**', '*.min.js']]])
|
|
})
|
|
|
|
test('a boolean field writes a real boolean', async () => {
|
|
const { draw, drawOpen } = registered()
|
|
const scope = fakeScope(READY)
|
|
const checkbox = findAll(
|
|
drawOpen(scope),
|
|
(node) => node.type === 'input' && node.props['aria-label'] === 'Install slopo with uv when missing',
|
|
)[0]
|
|
checkbox.props.onChange({ target: { checked: true } })
|
|
await buttonStartingWith(draw(scope), 'Save').props.onClick()
|
|
assert.deepEqual(scope.calls.set, [['autoInstall', true]])
|
|
})
|
|
|
|
test('an overridden field is marked, and Reset clears every override', async () => {
|
|
const { drawOpen } = registered()
|
|
const scope = fakeScope({
|
|
...READY,
|
|
value: { embeddingModel: 'ollama/x:latest', embeddingDimensions: 768 },
|
|
user: { embeddingModel: 'ollama/x:latest', embeddingDimensions: 768 },
|
|
})
|
|
const tree = drawOpen(scope)
|
|
const labels = findAll(tree, (node) => node.type === 'label').map(textOf)
|
|
assert.ok(labels.some((label) => label.includes('overridden')), 'a user-set field must be marked')
|
|
|
|
const reset = buttonStartingWith(tree, 'Reset')
|
|
assert.equal(reset.props.disabled, false)
|
|
await reset.props.onClick()
|
|
assert.deepEqual(scope.calls.unset.sort(), ['embeddingDimensions', 'embeddingModel'])
|
|
})
|
|
|
|
test('a read-only namespace says so and disables every control', () => {
|
|
const { drawOpen } = registered()
|
|
const tree = drawOpen(fakeScope({ ...READY, writable: false, mode: 'memory' }))
|
|
assert.match(textOf(tree), /read-only/)
|
|
const inputs = findAll(tree, (node) => node.type === 'input')
|
|
assert.ok(inputs.length > 0)
|
|
for (const input of inputs) assert.equal(input.props.disabled, true)
|
|
})
|