James Mackay
73e886dafe
fix(config_flow): F-A/F-A2/F-D — the discovered host and the 5555 port ride the schema KEY defaults (t33)
...
F-A (HIGH): _user_schema_dict re-declared vol.Optional(CONF_ADB_HOST) /
CONF_PROTOCOL_HOST inside `if "host" in defaults:` — a no-op, because
voluptuous keys compare by field name and the first (defaultless) key object
survives. The discovered address therefore never reached the form, and the
user submitted a blank host. The host keys are now declared WITH default=host
(_host_field_key), so a discovery-driven user step arrives pre-filled.
F-A2: a discovery-driven user step says the address is known
("{discovery_note}Discovered Shield at <host> — its address is already filled
in below. ") through description_placeholders, and the no_state_source
re-render keeps the prefill instead of rebuilding a blank schema.
F-D: the ADB port is declared with default=DEFAULT_ADB_PORT (5555), and a YAML
seed's port hint is carried into the form instead of being flattened to 5555.
The seed host now feeds _seed_host (same prefill, no discovery claim).
Reproduce-through-test: tests/voluptuous_mirror.py mirrors the real
voluptuous.Marker key contract (hash/eq by field name, default=UNDEFINED when
omitted), because voluptuous is not installed in either CI variant and the old
bare-key stubs could not tell a schema WITH a default from one without. The
pre-t33 discovery assertion only checked the stored attribute and stayed green
while the form rendered blank; it now reads the schema keys and fails on the
pre-fix code (8 tests reproduced red locally).
Verified: uvx --with pytest-asyncio pytest tests -q → 242 passed, 1 skipped;
uvx ruff check custom_components tests → clean.
2026-10-10 20:50:16 +01:00
James Mackay
c20146b08b
fix(init,config_flow): F4 — seed blocks and the import prefill honor the block's shape: ADB only when the block carries an adb host, protocol-only blocks keep adb_enabled off; TestSeedBlockShapeF4 pins all three paths (t32)
2026-10-09 08:04:41 +01:00
James Mackay
6087566336
fix(config_flow): F2 — MAC-less zeroconf discovery calls the audited _async_handle_discovery_without_unique_id helper and guards against a same-host duplicate prefill, so re-discovery can't stack entries; the import guard reads entries via the base _async_current_entries helper; TestMacLessDiscoveryF2 pins helper call + one-entry outcome (t32)
2026-10-09 08:04:05 +01:00
James Mackay
8f40b6435c
fix(poller): F1 — the poller factory re-reads entry.options at call time (audit-sanctioned option), so the next built poller targets the NEW address after a zeroconf IP change; the stale live-read comment in config_flow points at the actual mechanism; TestIpChangeSelfHealF1 drives an IP change and pins the next poller host (t32)
2026-10-09 08:03:28 +01:00
James Mackay
c1a82a2fa5
fix(diagnostics): hosts join the explicit TO_REDACT list per the audit's G14 citation (t30 G14)
2026-10-09 07:47:12 +01:00
James Mackay
297f8a21a7
docs(readme,strings): YAML seed-only semantics documented — interactive flow, duplicate guards, no implicit entry changes on block removal (t30 U1)
2026-10-09 07:24:52 +01:00
James Mackay
a6eeae86e9
feat:init,config_flow: YAML seed-only setup — an optional nvidia_shield block starts interactive SOURCE_IMPORT flows (parsed in async_setup), the import step guards duplicates by host/MAC-virtual unique_id and never re-seeds UI-configured hosts, protocol fields are prefill hints only (t30 U1)
2026-10-09 07:24:39 +01:00
James Mackay
2e70587871
feat: standards polish — G7 sensor translation_key naming + entity strings, G10 protocol-push device identity on the registry card, G12 unrecorded poll-driven attributes (media player DAG internals + sensors), G14 async_redact_data with an explicit redaction list behind the marker scan (t30)
2026-10-09 07:22:23 +01:00
James Mackay
194a97ce34
feat(button,media_player): Pair ADB carries entity_category CONFIG (t30 G11) + BrowseMediaSource domain parameter at root and children (t30 G18, 2026-05-20 blog contract); stubs/tests pin both
2026-10-09 07:17:14 +01:00
James Mackay
7c12d96070
feat(icon): HACS-required 256x256 icon.png placeholder, generated (t30 G15)
2026-10-09 07:15:42 +01:00
James Mackay
a5254b4740
feat(manifest): integration_type device + domain loggers adb_shell/androidtvremote2 (t30 G1)
2026-10-09 07:15:42 +01:00
James Mackay
383ec5ada5
feat(config_flow): commit the G2 + stub wiring lost in the amend cycle — device-MAC unique_id derivation in the flow, device-registry stubs across the flow suites
2026-10-09 07:11:11 +01:00
James Mackay
e1a0fc3039
feat(config_flow): the G2 unique_id fix lands — the androidtv entity_id is never a unique_id; MAC derived from the device registry mac connection (empty placeholders skipped), else no unique_id; rename-stability + absence pinned by test (t29 G2)
2026-10-09 07:11:03 +01:00
James Mackay
086c089cc1
fix: commit G3a wiring lost in the amend cycle — listener removal, update-only host path, reauth via the current API (stub surface includes async_update_reload_and_abort)
2026-10-09 07:03:33 +01:00
James Mackay
bcb8b962e7
fix: the deprecated listener+reload combo is gone — reauth uses async_update_reload_and_abort(_get_reauth_entry()), zeroconf host update is update-only, the __init__ options-reload listener is removed (grep-pinned); host-change tests assert update-without-reload (t29 G3a)
2026-10-09 07:02:21 +01:00
James Mackay
e51545262e
fix(connection,adb_client): commit the F-NEW1..3 wiring lost in the amend cycle — no-idle-timeout transport budget with in-code rationale, config accessor consumption, wrapped-line buffer
2026-10-09 06:20:46 +01:00
James Mackay
9b3142874f
fix(connection,adb_client): the logcat stream survives quiet windows — transport_timeout_s=None (bulk_read blocks quiet gaps; the ladder + async_stop remain recovery/cleanup), 3-line parse buffer for wrapped cmp records, public poller config accessor replaces the private reach-ins (t27 F-NEW1..3)
2026-10-09 06:20:38 +01:00
James Mackay
6c925c5241
chore(config_flow): replace the stranded self-answering comment in the options editor with a plain statement (t26 F5)
2026-10-09 06:11:58 +01:00
James Mackay
3587747c72
fix(media_player): unique_id migration pre-checks for an existing entry holding the target MAC — falls back to the config-entry id on collision (t26 F4)
2026-10-09 06:11:36 +01:00
James Mackay
b442440ccf
fix(connection,app_labels): negative-cache label-less packages (same 24h TTL, no re-enqueue — kills the per-heartbeat pm dump tax) + shlex.quote the pm dump package argument (t26 F1,F2)
2026-10-09 06:08:33 +01:00
James Mackay
697e3ba307
feat(connection,const,strings): complete the P5-3 logcat consumer wiring lost in an earlier amend — dedicated stream, instant stamp, ladder + auto-disable, default-off toggle strings
2026-10-09 06:06:34 +01:00
James Mackay
07cb73fbb7
feat(config_flow,strings): CONF_LOGCAT_EVENTS options toggle (default off, stability-report wording) (P5-3)
2026-10-09 06:03:28 +01:00
James Mackay
a3b397920e
test(config_flow,media_player,remote): digit-delay/send-enter options (store + window/error validation), IME-first text entry with ADB fallback tier, icon column parse/prefill/store (P5-2)
2026-10-09 06:00:17 +01:00
James Mackay
3d026ae60e
feat(config_flow): digit-delay (0.05–1.0 s, invalid input error) + optional send-enter options UI consumed by the §7 channel path; strings/README updated (P5-2.1)
2026-10-09 05:55:07 +01:00
James Mackay
4661e52041
fix(ha_adb_common): application-label regex accepts double-quoted labels too (completes the P5-1 parser tolerance)
2026-10-09 05:52:21 +01:00
James Mackay
c57a2e2ff2
test(ha_adb_common,connection): application-label tolerance (dual quotes, empty multi-label blocks, null, absent) + label cache reuse across cycles — no duplicate pm dump (P5-1)
2026-10-09 05:52:02 +01:00
James Mackay
cd0e634a76
feat(connection,media_player): on-demand manifest-label cache (≥24h TTL, one pm dump per watchdog cycle via the task pool) + app_name order map > label > entity > raw package (P5-1)
2026-10-09 05:48:39 +01:00
James Mackay
80e9a691bc
feat(ha_adb_common): application-label parser — default-locale from pm dump, localized variants skipped, tolerant of empty/multi-label blocks (P5-1)
2026-10-09 05:47:30 +01:00
James Mackay
17648f43c9
fix(media_player): store the computed adb_command participant key on the entity — completes the F4 add/remove key symmetry in the lifecycle hooks
2026-10-08 11:22:23 +01:00
James Mackay
f03ef1f531
fix(config_flow): per-host zeroconf updates — blank auto-detect hosts self-heal from the discovery address, a deliberately-different ADB host is never clobbered, same-IP with both hosts current is a no-op (F2)
2026-10-08 11:22:04 +01:00
James Mackay
b37a14b920
fix(media_player): the adb_command participant registry key is computed once at registration and stored on the entity — add/remove always match (F4)
2026-10-08 11:21:09 +01:00
James Mackay
c44c2c2170
feat(const,strings,readme): adb_command consts/service name, options toggle strings, curated DEFAULT_APP_DIRECTORY and README service notes (completes P4-2 unit 1)
2026-10-08 11:13:09 +01:00
James Mackay
326f02cb59
feat(media_player): BrowseMedia app directory — root lists the options apps map (curated TiviMate/Wholphin/Netflix/YouTube fallback), selection launches via play_media(app) (P4-2c)
2026-10-08 11:12:37 +01:00
James Mackay
034cb5c83d
feat(media_player): option-gated adb_command service (default off; registered at setup, unregistered at last unload, ADB-down rejection) + redacted entry diagnostics (P4-2a,b)
2026-10-08 11:08:57 +01:00
James Mackay
4222027602
feat(const,config_flow): option-gated adb_command service switch (default off) + curated app directory consts + README service/security notes (P4-2)
2026-10-08 11:07:28 +01:00
James Mackay
f4d750ff92
test(config_flow): zeroconf discovery (pre-fill, no-host abort, IP-change host update, same-IP skip) + apps map editor (store/parse/clear/prefill) + app_name map resolution tiers (P4-1)
2026-10-08 11:03:28 +01:00
James Mackay
61c7ac99a3
feat(config_flow,media_player): apps name/icon map editor in the options flow (package=name per line, invalid input error) + app_name resolves through CONF_APP_NAME_MAP after the entity/push tiers (P4-1b)
2026-10-08 10:58:04 +01:00
James Mackay
1dbb695cec
feat(config_flow): zeroconf discovery step — pre-filled user step from the discovery address, duplicate-MAC abort, IP-change host update + reload for known entries (P4-1a)
2026-10-08 10:57:31 +01:00
James Mackay
8b4fea9a5c
feat(const,manifest): zeroconf service type + CONF_APP_NAME_MAP; manifest declares the _androidtvremote2._tcp discovery dependency (P4-1)
2026-10-08 10:57:08 +01:00
James Mackay
ce90f59f8e
fix(config_flow): no_state_source fires only when none of the three sources is present — ADB-only standalone is valid; strings/docs name all three (F2)
2026-10-08 10:52:44 +01:00
James Mackay
3b8e97fe5b
fix(media_player): privacy bare-app identity outranks the channel-title fallback in the foreground tier (F3)
2026-10-08 10:52:24 +01:00
James Mackay
392553ee26
fix(media_player): channel-title fallback gated to the channel app (TIVIMATE_PACKAGE or audio_playback membership) — launcher never shows a channel number (F1)
2026-10-08 10:52:08 +01:00
James Mackay
bc457baae7
feat(media_player): foreground tier in the state ladder with app-source now-playing (last-known → last_channel → audio hint), sensor reads the store's foreground priority chain (P3-3a,c)
2026-10-08 10:45:58 +01:00
James Mackay
1f0a4b2021
feat(running_apps): media_dag_running_apps enrichment — TTL-capped last_known_state/last_known_title for apps without a live session (P3-3b)
2026-10-08 10:42:41 +01:00
James Mackay
aa4ee7ed62
feat(connection): TTL-filtered last_known_map snapshot of the per-package cache (P3-3b feed)
2026-10-08 10:42:24 +01:00
James Mackay
bb2f787fcd
test(ha_adb_common): fixture-driven foreground-parser tests — TiviMate capture, R4 launcher, wrap join, topResumed fallback ordering, duplicates tolerated (P3-2a)
2026-10-08 10:39:43 +01:00
James Mackay
8885ddd5b5
feat(connection): ADB foreground fallback on the watchdog cadence when the protocol push is silent (store priority protocol > ADB); audio-playback hint filtered through SYSTEM_MEDIA_PACKAGES (P3-2b,c)
2026-10-08 10:33:38 +01:00
James Mackay
f1e49a661b
feat(ha_adb_common): foreground parser — mResumedActivity primary with block-join for ActivityRecord wraps, topResumedActivity fallback (R4); no window-focus parsing
2026-10-08 10:32:39 +01:00
James Mackay
34d09e9f70
feat(media_player): app_id/app_name prefer the androidtv entity, fall back to the protocol current_app push when absent/unavailable; manifest androidtvremote2 floor aligned to >=0.2.0 (P3-1b,c)
2026-10-08 10:28:56 +01:00
James Mackay
d35b61078d
feat(config_flow): standalone setup — androidtv entity optional with no_state_source validation, entry data omits the field for standalone entries, sensor tolerates its absence; migration keeps v1 field / v2 absence valid (P3-1a,d)
2026-10-08 10:28:56 +01:00
James Mackay