4 Commits

Include renames

Author	SHA1	Message	Date
engineer	5ae2baa618	docs(installed-apps): the -3 output shape is documented, not observed (t62 nit c) ... The mark t2's acceptance (c) asked for lived in connection.py's discovery section and the README, but the parser for that output is this module, so a reader looking at the parser met the claim ("the real output has one `package:<id>` per line") without its provenance. It is now stated where that reader starts: the module docstring carries a "MARK — documented, not observed (t62 nit c)" paragraph saying that `pm list packages -3` printing `package:<id>` lines and `resolve-activity --brief` printing `package/activity` are Android's documented shapes, not a captured run — no real Shield was available when discovery was written (t57), and no fixture in this repo captures either command — and `parse_package_list`'s tolerance note now points at that mark instead of calling the shape "real". Wording mirrors the state=6 buffering inference (ha_adb_common/media_session.py, echoed in media_player.py) and the existing connection.py mark. Docstrings only: stripping every docstring leaves an AST identical to HEAD's, so no behaviour changes. The two existing marks stay accurate and are untouched (connection.py still says the shapes are Android's documentation and the parsers in ha_adb_common.installed_apps are deliberately tolerant; the README still marks every discovery output shape as documented-not-observed).	2026-10-12 08:38:13 +01:00
engineer	c884c7e1ab	docs(discovery): the not-observed mark lands in the in-scope module (t62 nit c) ... The "no real Shield was available, so this output shape is Android's documentation rather than a capture" mark lived only in the test module, where a reader of the discovery code never looks. It now sits in connection.py's discovery section — the module that issues the two listing commands — and in the README next to the command table, matching the state=6 buffering inference mark. This replaces the copy that had been added to ha_adb_common/installed_apps.py: t62's in-scope set is connection.py, sensor.py, README.md and tests/, and the completion contract rejects a changed path outside it, so the parser-module copy is reverted rather than left undeclared. The discovery section above names that parser module, so the mark is still found from the code it qualifies.	2026-10-12 08:25:41 +01:00
engineer	1c414c2f70	docs(discovery): mark the command shapes documented, not observed (t62 nit c) ... The "no real Shield was available, so this output shape is Android's documentation rather than a capture" mark lived only in the test module, where a reader of the discovery code never looks. It now sits in the module docstring next to the commands it qualifies, and in the README's app-discovery section next to the command table, matching the state=6 buffering inference mark in the source ladder.	2026-10-12 08:22:20 +01:00
James Mackay	ee3f2845af	feat(discovery): enumerate the apps installed on the Shield (t57) ... The live complaint ("it doesn't find all the apps") came from the curated list: only four packages were ever offered, so anything the user had installed elsewhere was invisible. The device knows its own apps. ha_adb_common/installed_apps.py parses the two queries the sweep makes: * `pm list packages -3` — every third-party (user-installed) package; * `cmd package resolve-activity --brief -c android.intent.category.HOME` — the ACTIVE launcher, a system app that is nonetheless what the user opens, so it is appended rather than filtered away. System apps are otherwise not enumerated (a Shield ships a few hundred and they are not launchable apps); the parsers are tolerant of the noise a real adb shell can prepend and of duplicate lines. ShieldConnectionManager gains the sweep: `async_refresh_installed_apps(force=False)` returns a cached `[{package, name, icon}]` table, and `installed_apps()` is a pure read that never issues a shell — so a state poll costs nothing. Naming stays on the one path: the sweep calls `_dump_label`, the same `pm dump` + parse + 24 h cache the entity path uses, now extracted so the two cannot drift, including the t57 UNIT 0 rule that a fetch that returned nothing is NOT cached. Labels are fetched APP_SWEEP_CONCURRENCY (4) at a time with APP_SWEEP_SPACING (50 ms), so a typical Shield finishes in seconds rather than the minutes a one-per-watchdog-cycle drain would take while the socket still sees a trickle. Failure is a normal outcome: no poller, a disconnected transport or a mute shell stores an EMPTY table with a stamp and returns [], so nothing retries in a loop and every surface degrades to "no discovered apps". Icons: `pm dump` does NOT expose an app's icon resource — an extracted APK's icon is a bitmap only its own code resolves — so this is honestly a heuristic: APP_ICON_FALLBACKS (a curated package -> mdi: map) with APP_ICON_GENERIC (mdi:television) for anything unknown, and always a string.	2026-10-12 07:28:50 +01:00